Print human-readable titles alongside MCP server identifiers in list subcommand#760
Merged
Conversation
rhernandez35
commented
Jun 10, 2025
|
|
||
| public interface Registry { | ||
|
|
||
| final class RegistryEntry { |
Collaborator
Author
There was a problem hiding this comment.
This is intentionally not a record. I don't want this to be usable in record destructuring statements.
adwsingh
approved these changes
Jun 10, 2025
| .getColorScheme() | ||
| .string("@|bold " + bundle.getName() + (isInstalled ? " [installed]" : "") + "|@")); | ||
| .string("@|bold " + bundle.getName() + (isInstalled ? " [installed]" : "") + "|@: " | ||
| + entry.getTitle())); |
Contributor
There was a problem hiding this comment.
Can you add a println at the end of description. Otherwise descriptions are clobberred.
Collaborator
Author
There was a problem hiding this comment.
What do you mean by "clobbered?" The output appears fine on my screen, if not a bit cramped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now print a friendly title with each server. The server identifier is bolded so users will know to use it with
start-serverandinstall. We can move the title into the body of the listing if we think we'll need additional clarity.